-
Notifications
You must be signed in to change notification settings - Fork 15
feat(utils): implement custom logger with groups and tasks #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit d3ff1a9
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 963eebd
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
963eebd to
f525e5c
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit d073ab6 with previous commit 42fa531. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👎 1 group regressed, 👍 9 audits improved, 👎 4 audits regressed, 15 audits changed without impacting score🗃️ Groups
17 other groups are unchanged. 🛡️ Audits
582 other audits are unchanged. |
1b97d8c to
4fd1e6c
Compare
4fd1e6c to
d3ff1a9
Compare
vmasek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work 👏🏻
Part of #888
This PR implements and tests a new custom
Loggerclass, intended to replace our current logging with@poppinss/cliui,multi-progress-bars, etc. To minimize the scope of this PR, the newloggeris unused. I've included a demo script and have tested the implementation manually in GitHub Actions and GitLab CI/CD. There's a comprehensive integration test suite and documentation.Features
ansis).--verboseflag orCP_VERBOSEenvironment variable.ora).GITHUB_ACTIONSorGITLAB_CIenvironment detected.Examples
🎥 Default (local) - colors, spinners, groups
screen-capture.-.2025-10-17T175651.556.webm
🎥 Verbose - debug logs
screen-capture.-.2025-10-17T175515.228.webm
🎥 CI - spinners disabled
screen-capture.-.2025-10-17T180140.476.webm
🖼️ GitHub Actions - groups log lines using workflow commands (always collapsed by default)
source: workflow run
🖼️ GitLab CI/CD - renders collapsible sections (collapsed by default, unless verbose)
source: pipeline run
🎥 Error handling in plugin - completes spinner and group before re-throw
screen-capture.-.2025-10-17T180300.976.webm
🎥 Error handling in core - completes spinner before re-throw
screen-capture.-.2025-10-17T180344.316.webm
🎥 Error handling for
SIGINTcancellation - completes spinner before exitingscreen-capture.-.2025-10-17T180603.703.webm