-
Notifications
You must be signed in to change notification settings - Fork 15
fix(ci): prevent parallel git diff when detecting new issues in monorepo #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 5176de7
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit c4a8b09 with previous commit 5b4069a. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👍 2 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score🗃️ Groups
19 other groups are unchanged. 🛡️ Audits
590 other audits are unchanged. |
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
3 different monorepos have encountered the same bug, recently. It happens towards the end of the run, after bulk compare has completed succesfully.
After inspecting the source code, I believe the cause was
findNewIssuesbeing run in parallel, because it performs Git operations -git fetch origin main --depth=1followed bygit diff FETCH_HEAD HEAD ...- which fit the error message.Refactored to ensure these operations are run sequentially.