Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 27, 2025

This PR includes:

  • added MVP custom lint formatter under tools
  • add lint-report to nx.json#defaultTargets

Task Graph:
Screenshot 2025-09-02 at 13 51 18

Note

This enables us to reuse the lint work. We always create json + terminal output and in the conformance target we just depend on the targets and consume the output. In the past we where running the lint work 2 times as it is not possible to get terminal for DX and json for conformance

Related:

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling labels Aug 27, 2025
@nx-cloud
Copy link

nx-cloud bot commented Aug 27, 2025

View your CI Pipeline Execution ↗ for commit f56ba9e

Command Status Duration Result
nx code-pushup --nx-bail -- compare --verbose ✅ Succeeded 1m 2s View ↗
nx code-pushup --nx-bail -- --verbose ✅ Succeeded 1m 29s View ↗
nx code-pushup --nx-bail -- print-config --verb... ✅ Succeeded 4m 8s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-03 12:33:59 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 27, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1090

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1090

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1090

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1090

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1090

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1090

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1090

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1090

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1090

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1090

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1090

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1090

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1090

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1090

commit: f56ba9e

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 6795d67 with previous commit aa4540a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🔴 36 ↑ +3.8
Documentation 🔴 23 🔴 24 ↑ +1.4
Code coverage 🟢 90 🟡 90 ↓ −0.7
Security 🟡 64 🟡 64
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 7 audits improved, 👎 4 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🔴 36 ↑ +3.8
JSDoc coverage Documentation coverage 🔴 23 🔴 24 ↑ +1.4
Code coverage Code coverage metrics 🟢 90 🟡 90 ↓ −0.7

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 7.2 s 🟥 5.9 s ↓ −17.4 %
JSDoc coverage Types coverage 🟥 236 undocumented types 🟥 236 undocumented types  +0 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟨 3.0 s ↓ −8.7 %
Lighthouse Total Blocking Time 🟥 3,940 ms 🟥 2,370 ms ↓ −39.8 %
Lighthouse Time to Interactive 🟥 18.2 s 🟥 16.6 s ↓ −9.3 %
Code coverage Line coverage 🟨 87.2 % 🟨 86.2 % ↓ −1.2 %
Lighthouse Max Potential First Input Delay 🟥 1,440 ms 🟥 710 ms ↓ −50.5 %
Code coverage Branch coverage 🟨 86.2 % 🟨 85.5 % ↓ −0.9 %
Code coverage Function coverage 🟩 92.8 % 🟩 92.2 % ↓ −0.6 %
JSDoc coverage Functions coverage 🟥 517 undocumented functions 🟥 518 undocumented functions ↑ +0.2 %
JSDoc coverage Variables coverage 🟥 229 undocumented variables 🟥 289 undocumented variables ↑ +26.2 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,724 KiB 🟨 Total size was 2,678 KiB ↓ −1.7 %
Lighthouse Minimizes main-thread work 🟥 16.2 s 🟥 10.5 s ↓ −35.3 %
Lighthouse JavaScript execution time 🟥 6.8 s 🟥 4.2 s ↓ −38.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −9.3 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 10.7 s ↓ −7.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↑ +27.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 591 KiB 🟥 Potential savings of 583 KiB ↓ −5.2 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 70 ms ↑ +170.5 %
Lighthouse Initial server response time was short 🟩 Root document took 420 ms 🟩 Root document took 450 ms ↑ +5.8 %
Lighthouse Server Backend Latencies 🟩 1,360 ms 🟩 1,380 ms ↑ +1.5 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 101 KiB 🟥 Potential savings of 92 KiB ↓ −6.2 %
Lighthouse Cumulative Layout Shift 🟩 0.001 🟩 0 ↓ −100 %

586 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review August 27, 2025 19:13
@BioPhoton BioPhoton requested a review from matejchalk August 28, 2025 14:19
BioPhoton and others added 5 commits August 28, 2025 18:37
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@github-actions github-actions bot added the 🦾 CI/CD Continuous integration and deployment label Sep 1, 2025
@github-actions github-actions bot removed the 🦾 CI/CD Continuous integration and deployment label Sep 3, 2025
@BioPhoton BioPhoton requested a review from matejchalk September 3, 2025 11:37
matejchalk
matejchalk previously approved these changes Sep 3, 2025
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton merged commit 9a7e128 into main Sep 3, 2025
17 checks passed
@BioPhoton BioPhoton deleted the tools/custom-eslint-formatter branch September 3, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 eslint-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants