-
Notifications
You must be signed in to change notification settings - Fork 15
chore: add eslint formatter for multiple formats #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit f56ba9e
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 6795d67 with previous commit aa4540a. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 7 audits improved, 👎 4 audits regressed, 13 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
586 other audits are unchanged. |
16 tasks
matejchalk
requested changes
Aug 28, 2025
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
…nto tools/custom-eslint-formatter
matejchalk
reviewed
Sep 2, 2025
matejchalk
reviewed
Sep 2, 2025
# Conflicts: # project.json
…lint-formatter-multi
# Conflicts: # .github/workflows/ci.yml
matejchalk
previously approved these changes
Sep 3, 2025
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧩 eslint-plugin
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
lint-reporttonx.json#defaultTargetsTask Graph:

Note
This enables us to reuse the lint work. We always create json + terminal output and in the conformance target we just depend on the targets and consume the output. In the past we where running the lint work 2 times as it is not possible to get terminal for DX and json for conformance
Related:
plugin-eslint#1068