-
Notifications
You must be signed in to change notification settings - Fork 15
ci: fix codecov workflow - projects and targets inferred from nx graph #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 21e025d
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 21e025d
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 168bfc3 with previous commit 163f67f. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👍 4 audits improved, 👎 1 audit regressed, 12 audits changed without impacting score🗃️ Groups
20 other groups are unchanged. 🛡️ Audits593 other audits are unchanged. |
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the fix
Fixes a couple of problems with Codecov job:
unit-testandint-testtargets #1061 was merged, some jobs have been failing inmainbecauseint-testtarget was removed from a few projectsnx-plugin,create-cli,plugin-jsdocs,plugin-typescript)To make the workflow more robust and require less maintenance, I've added a script which generates the GitHub Actions
matrixstrategy from our Nx graph. Currently, that's:I've tested the workflow via temporary trigger here.