Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

This PR includes:

  • passing perts of the persist options to runner logic
  • adding a plugin slug as const for plugin-eslint

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 core 🧩 models 🧩 eslint-plugin labels Aug 27, 2025
@nx-cloud
Copy link

nx-cloud bot commented Aug 27, 2025

View your CI Pipeline Execution ↗ for commit 88b6766

Command Status Duration Result
nx code-pushup -- compare --verbose ✅ Succeeded 7s View ↗
nx code-pushup -- --verbose ✅ Succeeded 6m 25s View ↗
nx code-pushup -- print-config --verbose --outp... ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-27 14:27:34 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 27, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1087

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1087

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1087

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1087

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1087

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1087

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1087

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1087

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1087

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1087

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1087

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1087

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1087

commit: 88b6766

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit e73bfd1 with previous commit 7aab96e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 36 🔴 30 ↓ −6.7
Code coverage 🟢 91 🟢 91 ↓ −0.1
Documentation 🔴 23 🔴 23 ↓ −0.1
Security 🟡 64 🟡 64
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 3 groups regressed, 👍 2 audits improved, 👎 6 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 36 🔴 30 ↓ −6.7
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 640 ms 🟩 Root document took 400 ms ↓ −37.2 %
Lighthouse Reduce unused JavaScript 🟨 Potential savings of 581 KiB 🟥 Potential savings of 559 KiB ↑ +∞ %
Lighthouse Remove duplicate modules in JavaScript bundles 🟨 Potential savings of 100 KiB 🟥 Potential savings of 100 KiB ↑ +∞ %
Lighthouse Largest Contentful Paint 🟥 4.9 s 🟥 13.6 s ↑ +175.8 %
Lighthouse First Contentful Paint 🟥 3.5 s 🟥 3.4 s ↓ −4.7 %
Lighthouse Speed Index 🟥 9.6 s 🟥 10.2 s ↑ +5.4 %
Code coverage Branch coverage 🟨 86.4 % 🟨 86.4 % ↓ −0.1 %
JSDoc coverage Variables coverage 🟥 229 undocumented variables 🟥 230 undocumented variables ↑ +0.4 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,673 KiB 🟨 Total size was 2,667 KiB ↓ −0.2 %
Lighthouse Server Backend Latencies 🟩 50 ms 🟩 550 ms ↑ +945.7 %
Lighthouse Minimizes main-thread work 🟥 26.2 s 🟥 25.7 s ↓ −1.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Total Blocking Time 🟥 9,370 ms 🟥 9,660 ms ↑ +3 %
Lighthouse Time to Interactive 🟥 19.6 s 🟥 19.8 s ↑ +1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1 %
Lighthouse JavaScript execution time 🟥 11.2 s 🟥 11.1 s ↓ −0.9 %
Lighthouse Max Potential First Input Delay 🟥 2,640 ms 🟥 2,560 ms ↓ −3.3 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↓ −4.3 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 30 ms ↓ −35.1 %
Code coverage Line coverage 🟨 87.6 % 🟨 87.6 % ↑ +0.1 %

590 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review August 27, 2025 14:20
@BioPhoton BioPhoton requested a review from matejchalk as a code owner August 27, 2025 14:20
@BioPhoton BioPhoton merged commit 163f67f into main Aug 27, 2025
18 checks passed
@BioPhoton BioPhoton deleted the feat/core/pass-config-to-plugin-runner branch August 27, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 core 🧩 eslint-plugin 🧩 models 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants