-
Notifications
You must be signed in to change notification settings - Fork 15
feat: implement scoreTargets for audits #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@code-pushup/ci
@code-pushup/create-cli
@code-pushup/models
@code-pushup/cli
@code-pushup/nx-plugin
@code-pushup/core
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit ccf38d8 with previous commit a419aec. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 2 audits regressed, 17 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
585 other audits are unchanged. |
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small naming change
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
View your CI Pipeline Execution ↗ for commit 5d86e2b
☁️ Nx Cloud last updated this comment at |
Part of #721 (CLI preparation)
This PR implements the CLI preparation phase for the
scoreTargetsfeature for audits.scoreTargetsproperty (single number or per-audit mapping)scoreAuditsWithTargetutility function in theutilspackagescoreTargetstransformation inexecutePluginafter the plugin executionThe following items from the ticket are intentionally deferred:
auditSchemawithtargetScore" - After careful consideration, it's been concluded thatscoreTargetbelongs at the plugin configuration level rather than individual audit definitions. This approach provides greater flexibility, allowing for either a single value applicable to all audits or a per-audit mapping.applyMaxScoreAboveThreshold" - This function remains in the coverage plugin unchanged. Migration to the new generic system is planned for PR4 to maintain backward compatibility.auditToGQLare not needed until PR3, after the portal model adoption (PR2) is complete.