Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 20, 2025

This PR includes:

  • mock files marked with extends-*
  • adjustments in loadTargetConfig to respect extends
  • added int tests
  • adjust vitest configs

Closes #1071

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 20, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1074

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1074

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1074

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1074

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1074

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1074

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1074

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1074

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1074

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1074

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1074

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1074

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1074

commit: 68350d8

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 30be15a with previous commit 44e4934.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 31 🔴 31 ↓ −0.7
Code coverage 🟢 90 🟢 90 ↑ +0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 31 🔴 31 ↓ −0.7
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.3 s ↑ +7.5 %
Lighthouse Time to Interactive 🟥 18.4 s 🟥 19.8 s ↑ +7.7 %
Code coverage Line coverage 🟨 87.1 % 🟨 87.4 % ↑ +0.3 %
Code coverage Branch coverage 🟨 86 % 🟨 86.1 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,678 KiB 🟨 Total size was 2,669 KiB ↓ −0.3 %
Lighthouse Server Backend Latencies 🟩 2,290 ms 🟩 180 ms ↓ −92 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +7.7 %
Lighthouse Minimizes main-thread work 🟥 21.5 s 🟥 20.7 s ↓ −3.4 %
Lighthouse Largest Contentful Paint 🟥 13.0 s 🟥 12.5 s ↓ −4 %
Lighthouse Total Blocking Time 🟥 6,890 ms 🟥 7,250 ms ↑ +5.2 %
Lighthouse JavaScript execution time 🟥 9.3 s 🟥 9.6 s ↑ +3.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 460 ms 🟩 Root document took 590 ms ↑ +30.3 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 90 KiB 🟥 Potential savings of 104 KiB ↓ −28.9 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 116 KiB ↓ −20 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 603 KiB 🟥 Potential savings of 614 KiB ↓ −11.1 %
Lighthouse Speed Index 🟥 8.7 s 🟥 8.7 s ↑ +1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 50 ms ↑ +126.4 %
Lighthouse Max Potential First Input Delay 🟥 2,290 ms 🟥 2,270 ms ↓ −1.1 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0.001 ↑ +∞ %

590 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review August 20, 2025 02:01
@BioPhoton BioPhoton requested a review from matejchalk August 20, 2025 02:06
@BioPhoton BioPhoton added 🐛 bug something isn't working 🚨 Hotfix Hotfix PR/issue labels Aug 20, 2025
matejchalk
matejchalk previously approved these changes Aug 21, 2025
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
matejchalk previously approved these changes Aug 21, 2025
@BioPhoton BioPhoton merged commit a419aec into main Aug 21, 2025
17 checks passed
@BioPhoton BioPhoton deleted the fix/plugin-typescript/load-extends branch August 21, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug something isn't working 🚨 Hotfix Hotfix PR/issue 🔬 testing writing tests 🛠️ tooling 🧩 typescript-plugin TypeScript plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typescript plugin can't resolve tsconfig from a library within the monorepo

3 participants