-
Notifications
You must be signed in to change notification settings - Fork 15
test: improve test coverage for plugin-coverage #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code PushUp🥳 Code PushUp report has improved – compared current commit bcd27c8 with previous commit 2ae961a. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👍 7 audits improved, 15 audits changed without impacting score🗃️ Groups
19 other groups are unchanged. 🛡️ Audits
588 other audits are unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the coverage improvement! as e2e tests do not improve coverage lets skip them for now. They also require more arrangement as we want to e2e test as little as possible.
Could we test this feature with unit tests too? And mock the projectGraph generation?
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/core
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed comments, LGTM
packages/plugin-coverage/src/lib/runner/lcov/lcov-runner.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/plugin-coverage/src/lib/runner/lcov/lcov-runner.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/plugin-coverage/src/lib/runner/lcov/lcov-runner.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/plugin-coverage/src/lib/runner/lcov/lcov-runner.unit.test.ts
Outdated
Show resolved
Hide resolved
packages/plugin-coverage/src/lib/runner/lcov/lcov-runner.unit.test.ts
Outdated
Show resolved
Hide resolved
|
View your CI Pipeline Execution ↗ for commit b29bb39
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit b29bb39 ☁️ Nx Cloud last updated this comment at |
Close #1054
This pull request improve test coverage (int, unit, e2e) for
plugin-coverage