Skip to content

Conversation

@AndriiSiuta
Copy link
Contributor

@AndriiSiuta AndriiSiuta commented Aug 8, 2025

Close #1054

This pull request improve test coverage (int, unit, e2e) for plugin-coverage

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Code PushUp

🥳 Code PushUp report has improved – compared current commit bcd27c8 with previous commit 2ae961a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 30 🔴 31 ↑ +1.4
Code coverage 🟢 90 🟢 91 ↑ +0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 2 groups improved, 👍 7 audits improved, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 30 🔴 31 ↑ +1.4
Code coverage Code coverage metrics 🟢 90 🟢 91 ↑ +0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 610 ms 🟩 Root document took 400 ms ↓ −35 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,707 KiB 🟩 Total size was 2,650 KiB ↓ −2.1 %
Lighthouse Properly size images 🟨 Potential savings of 5 KiB 🟩 0  −∞ %
Lighthouse Speed Index 🟥 9.6 s 🟥 8.1 s ↓ −15.6 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.3 s ↓ −3.8 %
Code coverage Line coverage 🟨 87.1 % 🟨 87.6 % ↑ +0.5 %
Code coverage Branch coverage 🟨 86 % 🟨 86.3 % ↑ +0.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 30 resources found ↓ −0.7 %
Lighthouse Server Backend Latencies 🟩 1,690 ms 🟩 160 ms ↓ −90.7 %
Lighthouse JavaScript execution time 🟥 11.6 s 🟥 10.2 s ↓ −11.6 %
Lighthouse Largest Contentful Paint 🟥 13.2 s 🟥 12.1 s ↓ −8.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −4.2 %
Lighthouse Time to Interactive 🟥 20.7 s 🟥 19.8 s ↓ −4.2 %
Lighthouse Minimizes main-thread work 🟥 22.3 s 🟥 21.5 s ↓ −3.9 %
Lighthouse Max Potential First Input Delay 🟥 2,400 ms 🟥 2,040 ms ↓ −15.3 %
Lighthouse Total Blocking Time 🟥 7,670 ms 🟥 7,830 ms ↑ +2.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 102 KiB 🟥 Potential savings of 116 KiB ↓ −26.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 92 KiB 🟥 Potential savings of 79 KiB ↓ −34.8 %
Lighthouse Avoids an excessive DOM size 🟥 2,329 elements 🟥 2,271 elements ↓ −2.5 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 40 ms ↓ −37.9 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 549 KiB 🟥 Potential savings of 614 KiB ↓ −2.2 %
JS Packages Outdated NPM dev dependencies. 🟨 55 outdated package versions (30 major, 21 minor, 4 patch) 🟨 57 outdated package versions (30 major, 21 minor, 6 patch) ↑ +3.6 %

588 other audits are unchanged.

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the coverage improvement! as e2e tests do not improve coverage lets skip them for now. They also require more arrangement as we want to e2e test as little as possible.

Could we test this feature with unit tests too? And mock the projectGraph generation?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 15, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1055

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1055

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1055

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1055

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1055

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1055

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1055

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1055

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1055

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1055

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1055

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1055

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1055

commit: b29bb39

@AndriiSiuta AndriiSiuta requested a review from BioPhoton August 15, 2025 08:50
BioPhoton
BioPhoton previously approved these changes Aug 15, 2025
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed comments, LGTM

@nx-cloud
Copy link

nx-cloud bot commented Aug 22, 2025

View your CI Pipeline Execution ↗ for commit b29bb39

Command Status Duration Result
nx code-pushup -- compare --verbose --before=/h... ✅ Succeeded 9s View ↗
nx code-pushup -- --verbose --no-progress --per... ✅ Succeeded 9m 15s View ↗
nx code-pushup -- print-config --verbose --outp... ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-22 08:54:14 UTC

@nx-cloud
Copy link

nx-cloud bot commented Aug 22, 2025

View your CI Pipeline Execution ↗ for commit b29bb39


☁️ Nx Cloud last updated this comment at 2025-08-22 08:44:09 UTC

@AndriiSiuta AndriiSiuta merged commit 6a961c2 into main Aug 22, 2025
28 of 29 checks passed
@AndriiSiuta AndriiSiuta deleted the plugin-coverage-test-improvements branch August 22, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin Coverage: Test Coverage Improvements

4 participants