Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Jul 9, 2025

Fixes bug reported by customer trying to integrate packages audit in Yarn v4.

Found out that in Yarn version 4, the output format of yarn npm audit --json changed completely compared to versions 2 and 3. Adjusted the stdout parsing logic to support both formats. Tested in rx-angular workspace.

@matejchalk matejchalk self-assigned this Jul 9, 2025
@github-actions github-actions bot added 🔬 testing writing tests 🧩 js-packages-plugin Plugin for audit and outdated dependencies labels Jul 9, 2025
@matejchalk matejchalk added the 🐛 bug something isn't working label Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 850ada2 with previous commit 73c2989.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 56 🔴 49 ↓ −7.4
Code coverage 🟢 90 🟢 90 ↑ +0.1
Documentation 🔴 23 🔴 23 ↓ −0.1
Security 🟡 61 🟡 61
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 6 audits regressed, 10 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 56 🔴 49 ↓ −7.4
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 3.9 s ↑ +13.6 %
Lighthouse Total Blocking Time 🟥 1,480 ms 🟥 2,800 ms ↑ +89.5 %
Lighthouse Speed Index 🟨 5.5 s 🟥 5.9 s ↑ +6 %
Lighthouse Time to Interactive 🟥 11.8 s 🟥 13.5 s ↑ +15 %
JSDoc coverage Functions coverage 🟥 476 undocumented functions 🟥 479 undocumented functions ↑ +0.6 %
JSDoc coverage Types coverage 🟥 223 undocumented types 🟥 225 undocumented types ↑ +0.9 %
Code coverage Function coverage 🟩 93.1 % 🟩 93.1 % ↑ +0.1 %
Code coverage Branch coverage 🟨 85.7 % 🟨 85.7 % ↑ +0.1 %
Code coverage Line coverage 🟨 86.5 % 🟨 86.6 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,935 KiB 🟩 Total size was 1,940 KiB ↑ +0.2 %
Lighthouse Minimizes main-thread work 🟥 10.3 s 🟥 14.0 s ↑ +36 %
Lighthouse JavaScript execution time 🟥 4.4 s 🟥 6.4 s ↑ +44.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +15 %
Lighthouse Max Potential First Input Delay 🟥 1,110 ms 🟥 1,690 ms ↑ +52.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Initial server response time was short 🟩 Root document took 460 ms 🟩 Root document took 370 ms ↓ −21 %
Lighthouse Server Backend Latencies 🟩 190 ms 🟩 140 ms ↓ −24.6 %
Lighthouse First Contentful Paint 🟨 2.9 s 🟨 2.9 s ↑ +0.2 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 10 ms ↑ +25.9 %

586 other audits are unchanged.

@matejchalk matejchalk merged commit 8041d87 into main Jul 9, 2025
19 checks passed
@matejchalk matejchalk deleted the yarn-v4-audit branch July 9, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug something isn't working 🧩 js-packages-plugin Plugin for audit and outdated dependencies 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants