Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Should fix error from codebase where Nx target is run in project directory 🤞

image

@matejchalk matejchalk self-assigned this May 19, 2025
@matejchalk matejchalk requested a review from vmasek May 19, 2025 10:41
@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 434369f with previous commit 1908892.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Best Practices 🟢 100 🟢 97 ↓ −3.4
Performance 🔴 43 🔴 41 ↓ −1.7
Code coverage 🟢 91 🟢 91 ↓ −0.1
Security 🟡 62 🟡 62
Updates 🟡 81 🟡 81
Accessibility 🟢 92 🟢 92
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 3 groups regressed, 👍 2 audits improved, 👎 4 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Best Practices 🟢 100 🟢 97 ↓ −3.4
Lighthouse Performance 🔴 43 🔴 41 ↓ −1.7
Code coverage Code coverage metrics 🟢 91 🟢 91 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse No browser errors logged to the console 🟩 passed 🟥 failed ↓ −100 %
Lighthouse Largest Contentful Paint 🟥 4.2 s 🟥 4.4 s ↑ +5.6 %
Lighthouse Speed Index 🟥 7.1 s 🟥 7.5 s ↑ +4.8 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.4 s ↓ −1.8 %
Lighthouse Time to Interactive 🟥 15.6 s 🟥 15.3 s ↓ −1.4 %
Code coverage Branch coverage 🟨 86.3 % 🟨 86.3 % ↓ −0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 28 resources found ↓ −0.9 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,866 KiB 🟩 Total size was 1,863 KiB ↓ −0.2 %
Lighthouse JavaScript execution time 🟥 9.4 s 🟥 8.6 s ↓ −8.5 %
Lighthouse Minimizes main-thread work 🟥 21.4 s 🟥 21.7 s ↑ +1.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,280 ms 🟥 Potential savings of 980 ms ↓ −23.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −1.4 %
Lighthouse Max Potential First Input Delay 🟥 2,950 ms 🟥 2,770 ms ↓ −6.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 57 KiB ↓ −50 %
Lighthouse Server Backend Latencies 🟩 240 ms 🟩 100 ms ↓ −58.9 %
Lighthouse Initial server response time was short 🟩 Root document took 540 ms 🟩 Root document took 420 ms ↓ −22.9 %
Lighthouse Total Blocking Time 🟥 7,220 ms 🟥 7,300 ms ↑ +1 %
Lighthouse Network Round Trip Times 🟩 80 ms 🟩 30 ms ↓ −57.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,180 elements 🟥 2,182 elements ↑ +0.1 %

586 other audits are unchanged.

@matejchalk matejchalk merged commit 61ae18e into main May 19, 2025
17 checks passed
@matejchalk matejchalk deleted the fix-print-config-output-path branch May 19, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants