Refactor Soroban exception filter to use typed error mapping#400
Open
Gezziy wants to merge 2 commits into
Open
Refactor Soroban exception filter to use typed error mapping#400Gezziy wants to merge 2 commits into
Gezziy wants to merge 2 commits into
Conversation
|
@TochukwuJustice is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Gezziy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #373
Summary of Changes:
Added SorobanErrorCode and ERROR_MAP for deterministic error-to-status mapping.
Replaced fragile substring-based Soroban error detection with structured error-code extraction.
Added support for Horizon result codes, Stellar RPC statuses, JSON-RPC numeric errors, timeout codes, errorResultXdr, and exact HostError(...) diagnostics.
Added focused unit tests for Soroban error mapping and fallback behavior.
Reason for the Changes:
The previous implementation depended on SDK error-message substring checks, which can silently break when Stellar SDK, Horizon, or Soroban RPC messages change. Typed error-code mapping is more stable, easier to test, and aligned with Stellar’s documented error structures.