Skip to content

improve(dx): clarify missing STELLAR_SERVER_SECRET error #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vic-Gray merged 2 commits into from
May 29, 2026
+8 −2
Merged

improve(dx): clarify missing STELLAR_SERVER_SECRET error #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d492caf
improve(dx): add descriptive stellar secret configuration error
Depo-dev May 29, 2026
428f1b7
Merge branch 'main' into improve/stellar-secret-error-316
vic-Gray May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion harvest-finance/backend/src/auth/strategies/stellar.strategy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ describe('StellarStrategy', () => {

expect(
() => new StellarStrategy(mockConfigService, mockUserRepository as any),
).toThrow('STELLAR_SERVER_SECRET environment variable is required');
).toThrow(
'Missing required environment variable: STELLAR_SERVER_SECRET. ' +
'Please define it in your .env file before starting the server.',
);
});

it('should use testnet network by default', () => {
Expand Down
5 changes: 4 additions & 1 deletion harvest-finance/backend/src/auth/strategies/stellar.strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ export class StellarStrategy extends PassportStrategy(

const serverSecret = configService.get<string>('STELLAR_SERVER_SECRET');
if (!serverSecret) {
throw new Error('STELLAR_SERVER_SECRET environment variable is required');
throw new Error(
'Missing required environment variable: STELLAR_SERVER_SECRET. ' +
'Please define it in your .env file before starting the server.',
);
}

this.serverKeypair = StellarSdk.Keypair.fromSecret(serverSecret);
Expand Down
Loading