Skip to content

fix(code-quality): clarify sanitizer errors and vault thresholds#351

Merged
vic-Gray merged 1 commit into
code-flexing:mainfrom
Dopezapha:feature-code-quality-vault-sanitizer
May 28, 2026
Merged

fix(code-quality): clarify sanitizer errors and vault thresholds#351
vic-Gray merged 1 commit into
code-flexing:mainfrom
Dopezapha:feature-code-quality-vault-sanitizer

Conversation

@Dopezapha
Copy link
Copy Markdown
Contributor

Closes #309
Closes #312

PR Description

This PR fixes two small backend code-quality issues: #309 and #312.

For #309, vault deposit thresholds are now named constants instead of inline numbers, making the maximum safe deposit and large-deposit alert cutoff easier to understand and maintain.

For #312, input sanitizer validation failures now return clearer messages that describe the expected format and include examples where useful. Stellar public key and contract ID validation now uses the Stellar SDK StrKey validators, so G-address and C-address inputs are checksum-aware instead of only shape-checked.

These changes improve reviewer and API-consumer clarity without changing the intended vault deposit flow.

Changed

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

@Dopezapha is attempting to deploy a commit to the vic's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 28, 2026

@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vic-Gray vic-Gray merged commit c4860de into code-flexing:main May 28, 2026
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#609 Improve error messages in InputSanitizerService #606 Extract magic numbers in vaults.service.ts to named constants

2 participants