fix(code-quality): clarify sanitizer errors and vault thresholds#351
Merged
vic-Gray merged 1 commit intoMay 28, 2026
Merged
Conversation
|
@Dopezapha is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
Closes #312
PR Description
This PR fixes two small backend code-quality issues: #309 and #312.
For #309, vault deposit thresholds are now named constants instead of inline numbers, making the maximum safe deposit and large-deposit alert cutoff easier to understand and maintain.
For #312, input sanitizer validation failures now return clearer messages that describe the expected format and include examples where useful. Stellar public key and contract ID validation now uses the Stellar SDK StrKey validators, so G-address and C-address inputs are checksum-aware instead of only shape-checked.
These changes improve reviewer and API-consumer clarity without changing the intended vault deposit flow.
Changed
MAX_SAFE_DEPOSITandLARGE_DEPOSIT_THRESHOLDinvaults.service.ts.