Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UIComponents/ColumnDetailsCategorical.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const ColumnDetailsCategorical = ({
getLocalizedValue(option, datasetId),
);
const barData = {
localizedLabels,
labels: localizedLabels,
datasets: [
{
label: id,
Expand Down
2 changes: 1 addition & 1 deletion src/indexDev.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import './assetPath';
import './setAssetPathDev';
import './setPublicPath';
import {initAll, instructionsDismissed} from './index';
import queryString from 'query-string';
Expand Down
20 changes: 20 additions & 0 deletions src/setAssetPathDev.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Dev-only: seed the asset-path global for the standalone dev host page.
//
// Production consumers (e.g. dashboard) call setAssetPath(...) themselves
// before loading the bundle, pointing it at wherever they serve the
// images + datasets. In dev the standalone index.html IS the consumer,
// so we inline the assignment here.
//
// Import this FIRST in indexDev.tsx so the global is set before either
// `setPublicPath` reads it for webpack's `__webpack_public_path__` OR
// the direct readers in `index.tsx` / `SelectDataset.tsx` build URLs
// from it. ESM guarantees depth-first evaluation in import order, so
// this module's body runs before any later import is evaluated.
//
// Value: './' — webpack emits images to `images/` (in-memory, served by
// webpack-dev-middleware) and `webpack-dev-server --static public`
// serves `public/datasets/*` at `/datasets/*` on disk. Both sit at the
// root, so the single-prefix model works.
import {setAssetPath} from './assetPath';

setAssetPath('./');
Loading