Skip to content

Switch to React functional components #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilkie wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Switch to React functional components #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aa762a
Upgrades to React 18.
wilkie Apr 9, 2026
5f4cebe
Switches to functional components.
wilkie Apr 9, 2026
c259cd5
Removes default React imports and externalizes the React runtime.
wilkie Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,14 @@ module.exports = {
"globals": {
},
"plugins": [
"jsx-a11y"
"jsx-a11y",
"react-hooks"
],
"extends": [
'plugin:react/recommended',
"eslint:recommended",
"plugin:jsx-a11y/recommended"
"plugin:jsx-a11y/recommended",
"plugin:react-hooks/recommended"
],
"env": {
"browser": true,
Expand All @@ -23,14 +25,11 @@ module.exports = {
"version": "detect"
}
},
"parser": "babel-eslint",
"parser": "@babel/eslint-parser",
"parserOptions": {
"sourceType": "module",
"ecmaFeatures": {
"jsx": true,
"modules": true,
"ecmaVersion": 6,
"experimentalObjectRestSpread": true
"jsx": true
}
},
"rules": {
Expand Down Expand Up @@ -58,6 +57,7 @@ module.exports = {
"no-useless-escape": "off",
"no-with": "error",
"object-curly-spacing": "off",
"react/react-in-jsx-scope": "off",
"react/button-has-type": "error",
"react/display-name": "off",
"react/jsx-closing-bracket-location": "error", // autofixable
Expand Down
2 changes: 1 addition & 1 deletion babel.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"presets": [
["@babel/preset-env", {"loose": true}],
"@babel/preset-react"
["@babel/preset-react", {"runtime": "automatic"}]
]
}
15 changes: 8 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,26 +32,27 @@
},
"devDependencies": {
"@babel/core": "^7.29.0",
"@babel/eslint-parser": "^7.28.6",
"@babel/preset-env": "^7.29.2",
"@babel/preset-react": "^7.28.5",
"babel-eslint": "^9.0.0",
"babel-jest": "29",
"babel-loader": "^10.1.1",
"copy-webpack-plugin": "11",
"core-js": "^3",
"css-loader": "^7.1.4",
"eslint": "6.1.0",
"eslint-plugin-jsx-a11y": "^6.4.1",
"eslint-plugin-react": "7.14.3",
"eslint": "8",
"eslint-plugin-jsx-a11y": "^6.10.2",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^7.0.1",
"identity-obj-proxy": "^3.0.0",
"jest": "29",
"messageformat": "2.3.0",
"ml-knn": "^3.0.0",
"query-string": "4.1.0",
"react": "~15.4.0",
"react-dom": "~15.4.0",
"react": "18",
"react-dom": "18",
"react-papaparse": "^3.8.0",
Comment on lines +52 to 54
Copy link
Copy Markdown
Member

@stephenliang stephenliang May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are exact pins, which we shouldn't use. Although not necessarily important because when we bring it to frontend, we'd use the catalog version instead. I'd prefer we use a more relaxed semver, but I leave that up to you if we are going to inline to the main repo soon.

"react-redux": "^5.0.0",
"react-redux": "9",
"redux": "^4.0.5",
"style-loader": "^4.0.0",
"webpack": "5",
Expand Down
Loading
Loading