Makes Pond Toggle Buttons Keyboard Navigable and ScreenReader Compliant #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
breville
reviewed
Jan 29, 2026
| <button | ||
| type="button" | ||
| onClick={this.toggleRecall} | ||
| aria-label="Toggle Identified Fish" |
Member
There was a problem hiding this comment.
The pond doesn't always show Fish vs. Trash; it varies by level. We should reuse the wording from the two buttons in the interactive training phase, which in the first level is "Fish" vs. "Not fish".
It might be easier to label this something like "Show matching items" vs. "Show non-matching items".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps the fontAwesomeIcons in buttons, which makes them keyboard navigable. It also adds aria labels to each so a students knows they are toggling to see fish or trash.
I tested via a symlink to the main repository- see the video below
Jira: https://codedotorg.atlassian.net/browse/SL-1548
Before: not much to video because the buttons weren't tab navigable at all
After:
Screen.Recording.2026-01-28.at.12.55.50.PM.mov
Followup: Make sure the student can then cycle through all the fish or trash floating in the pond to see how they did