Restore "Migrate UNIT_AND_LEVEL_TO_LESSON_S3_NAME to ai_rubric_s3_config on unit model"#71285
Open
davidsbailey wants to merge 1 commit intostagingfrom
Open
Conversation
51da9f3 to
3f7103b
Compare
…_s3_conf…" This reverts commit daa3981.
83a4f33 to
dfbbdea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
Background
Reverts #71278, restoring #71016.
I was able to get a local repro of the seeding issue which caused the original PR to be reverted. The root cause was that having the script cache enabled, combined with the changes in #71016 , causes script seeding to fail. the more specific reason is that
unit.ai_rubric_s3_configwas being set duringimport_scriptsbut that change was not visible later duringimport_learning_goalsdue to old unit state being stored in the script cache. invalidating the cache explicitly did not seem to fix, causing me to look into disabling script caching entirely during seeding.error details
Here is the error log from the initial failure in the test environment (slack):
Description
We don't need or want script caching during seeding anyway, so the solution is to disable script caching during seeding in #71467. once that PR is merged, this PR can be safely merged without additional changes.
Deployment notes
Unit.should_cache?is disabled, so we can just "proceed with normal caution" when shipping this PR.