Hide axis labels clipped at the chart edge#1295
Merged
Merged
Conversation
Adds a `hideClippedLabels` flag to Axis. When set, a boundary (first/last) label that would overflow the chart edge is dropped together with its tick. A label's reach toward an edge is estimated as a fraction of minLabelDistance based on its text anchor (start/end 80%, middle 40%). The check is made against the chart bounds (parentRect), not the axis bounds, so it is correct for inset axes and for multiple charts within one Svg. Minor ticks render via a separate path and are unaffected. Defaults to false on Axis and true on TimeAxis, where wide start-anchored labels make edge clipping the common case. Closes #1291
✅ Deploy Preview for cxjs-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1291 — on time axes the first/last label is anchored on a boundary tick and frequently gets clipped at the chart edge.
Adds a
hideClippedLabelsflag toAxis. When set, a boundary label that would overflow the chart edge is dropped — together with its tick.How it decides
A label's reach toward an edge is estimated as a fraction of
minLabelDistance(the minimum label spacing), scaled by the text anchor:labelAnchorstartmiddleendA label is dropped when
s + rightReach > chartBounds.rors - leftReach < chartBounds.l. This is pure geometry, so it handles first, last, andinvertedaxes automatically — no text measurement needed.Details
instance.parentRect(the chart's bounds), not the axis bounds — correct for an axis inset within its chart, and per-chart when oneSvghosts several charts.minLabelDistance≈ label width is a horizontal heuristic).Axisdefaultfalse;TimeAxisdefaulttrue— wide,start-anchored time labels make edge clipping the common case.Testing
yarn test: 508 passing;yarn check-types: clean.