Skip to content

fix: remove static secret and access keys #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CallMeLeopoldo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove static secret and access keys #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .do/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ CODACY_URL?="https://dev.k8s.dev.codacy.org"
GRAFANA_URL?="https://grafana.k8s.dev.codacy.org"
RELEASE_NAME?="codacy"
NAMESPACE?="codacy"
MINIO_ACCESS_KEY=$(shell openssl rand -hex 14)
MINIO_SECRET_KEY=$(shell openssl rand -base64 14)
HELM_REPOSITORY?=codacy-incubator
DEPLOYMENTS?=$(shell kubectl get deployments -n "${NAMESPACE}" | awk '{print $$1}' | tail -n +2 | grep -v minio)
WORKER_VERSION?=$(shell grep "engine" -A 2 ../codacy/requirements.lock | grep version | cut -d : -f 2 | tr -d '[:blank:]')
Expand All @@ -17,6 +19,8 @@ define call_helm_install
-f ../codacy/values-production.yaml \
-f values.yaml \
--namespace ${2} \
--set global.minio.secretKey=$${MINIO_SECRET_KEY} \
--set global.minio.accessKey=$${MINIO_ACCESS_KEY} \
--set global.imagePullSecrets[0].name=docker-credentials \
--set global.play.cryptoSecret=$${SHARED_PLAY_CRYPTO_SECRET} \
--set global.akka.sessionSecret=$${SHARED_AKKA_SESSION_SECRET} \
Expand Down
2 changes: 0 additions & 2 deletions codacy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ global:
create: true
location: codacy-minio
port: 9000
accessKey: "AKIAIOSFODNN7EXAMPLE"
secretKey: "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY"

s3:
bucket:
Expand Down