Vendor cockroach repo assets and remove external GitHub dependencies#23256
Open
ebembi-crdb wants to merge 1 commit intomainfrom
Open
Vendor cockroach repo assets and remove external GitHub dependencies#23256ebembi-crdb wants to merge 1 commit intomainfrom
ebembi-crdb wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ebembi-crdb
force-pushed
the
vendor-cockroach-docs-assets
branch
from
2d9a028 to
daf0546
Compare
Vendor static files (K8s manifests, Prometheus configs, Grafana dashboards, monitoring rules) into src/current/files/cockroach/ and generated docs into src/current/_includes/cockroach-generated/ so the docs site builds and serves without fetching from the cockroachdb/cockroach GitHub repo at build time or linking to it at read time. - Vendor 32 static files previously fetched via curl/wget - Vendor 88 generated doc files (8 files × 11 release branches) - Replace remote_include tags with local Jekyll includes - Replace remote_include version extractions with hardcoded values - Replace raw.githubusercontent.com download URLs with cockroachlabs.com paths - Unlink PR, issue, and commit reference-style and inline links - Update blob/tree links to point to vendored copies or plain text - Clean up release, repo, and comment references Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ebembi-crdb
force-pushed
the
vendor-cockroach-docs-assets
branch
from
daf0546 to
112d0fa
Compare
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/current/files/cockroach/so docs serve downloadable assets directly instead of linking to GitHubsrc/current/_includes/cockroach-generated/across 11 release branches, replacingremote_includebuild-time fetches with local Jekyllincludetagsremote_includeversion-string extractions intooling.mdwith hardcoded values from the Go source filesraw.githubusercontent.comdownload URLs tocockroachlabs.com/docs/files/cockroach/pathsTest plan
grep -rn 'raw.githubusercontent.com/cockroachdb/cockroach' src/returns zero matchesgrep -rn 'remote_include.*cockroachdb/cockroach' src/returns zero matches_site/docs/files/cockroach/[#NNN]brackets)curlcommand from the docs against localhost🤖 Generated with Claude Code