Skip to content

Use auto-generated session settings from CockroachDB source code#23251

Open
rmloveland wants to merge 3 commits intomainfrom
20260430-DOC-12507-automated-session-settings
Open

Use auto-generated session settings from CockroachDB source code#23251
rmloveland wants to merge 3 commits intomainfrom
20260430-DOC-12507-automated-session-settings

Conversation

@rmloveland
Copy link
Copy Markdown
Contributor

Fixes DOC-12507

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 39bc361
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/69fa2e63fb1e0300082fe285

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 39bc361
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/69fa2e634d33bd0009047309

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Netlify Preview

Name Link
🔨 Latest commit 39bc361
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/69fa2e63d03987000720ab66
😎 Deploy Preview https://deploy-preview-23251--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland rmloveland force-pushed the 20260430-DOC-12507-automated-session-settings branch from 9747974 to ab3c1d9 Compare May 5, 2026 16:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Files changed:

@rmloveland rmloveland requested a review from rafiss May 5, 2026 17:53
@rmloveland
Copy link
Copy Markdown
Contributor Author

@rafiss this is the docs update to pull in the autogenerated session settings you added in cockroachdb/cockroach#142228 !

Copy link
Copy Markdown
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! thanks for doing htis

Copy link
Copy Markdown
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this automation is badly needed and overdue, so thank you for making it happen.

That said, I'm concerned that it completely erases the manual documentation of the settings, which in many cases were more descriptive and refined. Modest example: inject_retry_errors_enabled here versus in our docs. I'm not sure how to address this gap. What do you think about it?

Technical issue: The code formatting in the autogenerated table is not rendering correctly. I think we encountered this in the logging reference docs but don't recall how we fixed it.

</div>

The following session variables are exposed only for backwards compatibility with earlier CockroachDB releases and have no impact on how CockroachDB runs:
**Read-only** indicates whether the variable can be changed in a session with [`SET`]({% link {{ page.version.version }}/set-vars.md %}). **Cluster Setting** identifies the [cluster setting]({% link {{ page.version.version }}/cluster-settings.md %}) that supplies the default value, when applicable.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Read-only** indicates whether the variable can be changed in a session with [`SET`]({% link {{ page.version.version }}/set-vars.md %}). **Cluster Setting** identifies the [cluster setting]({% link {{ page.version.version }}/cluster-settings.md %}) that supplies the default value, when applicable.
**Read-only** indicates whether the variable can be changed in a session with [`SET`]({% link {{ page.version.version }}/set-vars.md %}). **Cluster Setting** identifies the [cluster setting]({% link {{ page.version.version }}/cluster-settings.md %}) that supplies the default value for the cluster, when applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants