sql: add routine DDL/DCL execution metrics#170899
Draft
spilchen wants to merge 1 commit into
Draft
Conversation
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
Operators have no way to attribute DDL or DCL traffic to stored
procedures. The existing sql.routine.{select,update,insert,delete}.*
counters cover DML inside routines but leave schema and privilege
changes invisible, even though those statements are allowed inside
procedure bodies.
Extend the routine metric family with per-type counters for CREATE/DROP
TABLE (split by permanent vs temporary), CREATE/DROP SCHEMA, CREATE/DROP
ROLE, GRANT, REVOKE, and ALTER DEFAULT PRIVILEGES, following the
existing routine DML pattern.
Closes cockroachdb#170022
Release note (sql change): Added per-type counters for DDL and DCL
statements executed inside stored procedure bodies, exposed as
sql.routine.<type>.{started.count,count}.
Epic: CRDB-31256
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
spilchen
force-pushed
the
spilchen/gh-170022/260525/0202p/stored-proc-metrics
branch
from
dd03732 to
f324760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operators have no way to attribute DDL or DCL traffic to stored procedures. The existing sql.routine.{select,update,insert,delete}.* counters cover DML inside routines but leave schema and privilege changes invisible, even though those statements are allowed inside procedure bodies.
Extend the routine metric family with per-type counters for CREATE/DROP TABLE (split by permanent vs temporary), CREATE/DROP SCHEMA, CREATE/DROP ROLE, GRANT, REVOKE, and ALTER DEFAULT PRIVILEGES, following the existing routine DML pattern.
Closes #170022
Release note (sql change): Added per-type counters for DDL and DCL statements executed inside stored procedure bodies, exposed as sql.routine..{started.count,count}.
Epic: CRDB-31256