sql: use metamorphic defaults for optimizer testing knobs in logictest#170882
Open
lohitkolluri wants to merge 1 commit into
Open
sql: use metamorphic defaults for optimizer testing knobs in logictest#170882lohitkolluri wants to merge 1 commit into
lohitkolluri wants to merge 1 commit into
Conversation
Wire testing_optimizer_cost_perturbation and testing_optimizer_disable_rule_probability into logictest via metamorphic constants, matching other logictest fuzzing knobs. Improves coverage during metamorphic test runs alongside costfuzz and unoptimized-query-oracle. Fixes cockroachdb#93825 Release note: None
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
blathers-crl
Bot
added
O-community
Member
|
This change is |
yuzefovich
requested review from
a team and
michae2
and removed request for
a team and
yuzefovich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimizer-cost-perturbationanddisable-opt-rule-probabilityflagstesting_optimizer_cost_perturbationandtesting_optimizer_disable_rule_probabilitysession settings used by costfuzz and unoptimized-query-oracleFixes #93825
Test plan
./dev build pkg/sql/logictestRelease note: None