workload/tpcc: fix consistency checks for READ COMMITTED and snapshot…#170881
Open
cpj2195 wants to merge 1 commit into
Open
workload/tpcc: fix consistency checks for READ COMMITTED and snapshot…#170881cpj2195 wants to merge 1 commit into
cpj2195 wants to merge 1 commit into
Conversation
cpj2195
requested review from
herkolategan and
srosenberg
and removed request for
a team
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
… races Previously, `beginAsOfSystemTime` did not set an explicit isolation level, so it inherited the cluster default. When the default was READ COMMITTED, `SET TRANSACTION AS OF SYSTEM TIME` would fail with "unsupported in READ COMMITTED isolation". Fix by explicitly setting SERIALIZABLE isolation. Additionally, `check3322` and `check3324` acquired a timestamp inside a transaction, rolled it back, then ran queries outside the transaction using `AS OF SYSTEM TIME` with that timestamp. This created a race where concurrent TPC-C transactions could cause snapshot inconsistencies between the three queries. Fix by keeping the transaction open and running all queries within it, which guarantees a consistent snapshot. Resolves: cockroachdb#170876 Resolves: cockroachdb#170877 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
cpj2195
force-pushed
the
cpj/fix-tpcc-consistency-checks
branch
from
ad7709e to
ae9e477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
beginAsOfSystemTimedid not set an explicit isolation level, so it inherited the cluster default. When the default was READ COMMITTED,SET TRANSACTION AS OF SYSTEM TIMEwould fail with "unsupported in READ COMMITTED isolation". Fix by explicitly setting SERIALIZABLE isolation.Additionally,
check3322andcheck3324acquired a timestamp inside a transaction, rolled it back, then ran queries outside the transaction usingAS OF SYSTEM TIMEwith that timestamp. This created a race where concurrent TPC-C transactions could cause snapshot inconsistencies between the three queries. Fix by keeping the transaction open and running all queries within it, which guarantees a consistent snapshot.Resolves: #170876
Resolves: #170877
Epic: none
Release note: None