sql: some optimizations for deleteRangeNode#170872
Draft
yuzefovich wants to merge 2 commits into
Draft
Conversation
This commit implements a couple of minor optimizations for the deleteRangeNode: - if the table has only one column family, then we know that each deleted key corresponds to a different row, so we can skip decoding the prefix of each key. In turn, this allows us to leave the fetcher uninitialized. - we don't need to make a copy of spans in the beginning since we're holding the only reference to the slice and can modify it as we please. Release note: None
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements a couple of minor optimizations for the
deleteRangeNode:
deleted key corresponds to a different row, so we can skip decoding
the prefix of each key. In turn, this allows us to leave the fetcher
uninitialized.
holding the only reference to the slice and can modify it as we
please.
Touches: #138975
Epic: None
Release note: None