release-26.1: roachtest: skip revision history and zone config in mixed-version backup on pre-24.1 tenants#170868
Open
dt wants to merge 1 commit into
Open
release-26.1: roachtest: skip revision history and zone config in mixed-version backup on pre-24.1 tenants#170868dt wants to merge 1 commit into
dt wants to merge 1 commit into
Conversation
…kup on pre-24.1 tenants Zone configuration is not supported in virtual clusters on versions older than 24.1. When the mixed-version backup test runs with a multitenant deployment starting from a pre-24.1 version, the "configure gc policies" step fails with "operation is disabled within a virtual cluster". Rather than just skipping the GC TTL configuration, also skip revision_history backups for these pre-24.1 multitenant runs. The GC TTL only exists to bound MVCC history accumulation for revision history backups, so if we're not using revision history, we don't need the TTL either. AOST restore selection already checks withRevisionHistory() so it correctly avoids picking an AOST when revision history is not present. Fixes: cockroachdb#167512 Epic: none
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1 of 2 commits from #170069 on behalf of @dt.
(The second commit on the original PR is a CollectionConfig refactor of
infrastructure that does not exist on this branch, so it is omitted.)
Zone configuration is not supported in virtual clusters on versions
older than 24.1. When the mixed-version backup test runs with a
multitenant deployment starting from a pre-24.1 version, the
"configure gc policies" step fails with "operation is disabled within
a virtual cluster".
Rather than just skipping the GC TTL configuration, also skip
revision_history backups for these pre-24.1 multitenant runs. The GC
TTL only exists to bound MVCC history accumulation for revision history
backups, so if we're not using revision history, we don't need the TTL
either. AOST restore selection already checks withRevisionHistory() so
it correctly avoids picking an AOST when revision history is not
present.
Release justification: test-only roachtest fix for mixed-version backup pre-24.1 tenants