Skip to content

release-23.2: release tooling: bundled backport of GHA-migration follow-ups#170837

Open
rail wants to merge 1 commit into
cockroachdb:release-23.2from
rail:backport23.2-170348-170392-170657-170670-170686-170727-170765-170779
Open

release-23.2: release tooling: bundled backport of GHA-migration follow-ups#170837
rail wants to merge 1 commit into
cockroachdb:release-23.2from
rail:backport23.2-170348-170392-170657-170670-170686-170727-170765-170779

Conversation

@rail
Copy link
Copy Markdown
Member

@rail rail commented May 22, 2026

Backport of the GHA-migration follow-ups onto release-23.2 so the new GitHub
Actions release pipeline can drive 23.2 patch releases on behalf of @rail.

Mirrors the release-24.1 (#170823) recipe — pkg/cmd/release lifted from
release-26.1, GHA workflows + build/github/release-*.sh wrappers added,
shared TeamCity-era scripts lifted from release-26.1 (their edits are
additive WIF-auth branches gated on
CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE, so the legacy TeamCity code
paths still work).

Trimmed for release-23.2's scope. The following workflows / scripts
from upstream were intentionally dropped — they aren't run on this
branch:

  • IBM build/sign (build-per-platform-ibm, build-docker-ibm,
    ibm-signing, release-sign-ibm.sh) — release-23.2 doesn't ship IBM
    / linux-s390x.
  • Cloud-only image (publish-cloud-only, cloud-rollout,
    release-cloud-only.sh, release-cloud-rollout.sh,
    build-cockroach-release-cloud-only.sh).
  • RAFA rollout (create-rafa-prs, release-publish-rafa-prs.sh).

Dep changes mirror the 24.1 backport:

  • cockroachdb/version added as a new dep, go-github/v61 added, plus
    transitive bumps cockroachdb/errors v1.11.3, getsentry/sentry-go v0.27.0,
    google/go-cmp v0.6.0, stretchr/testify v1.10.0.
  • Orphaned legacy deps dropped: andygrunwald/go-jira,
    google/go-github/v42, indirect trivago/tgo. DEPS.bzl +
    distdir_files.bzl updated.

Branch-specific patches (same as 24.1):

  • verify_docker_image reverted to FIPS detection via Go version +
    OpenSSL fingerprint.
  • TEAMCITY_BUILD_PROPERTIES_FILE mount removed from run_bazel.
  • linux-s390x dropped from matrices and platform iteration.
  • build-cockroach-release-per-platform.sh uses
    publish-provisional-artifacts -provisional -release and restores
    the --build-arg fips_enabled=1 branch for the FIPS docker image.

Release justification: release-tooling backport for GHA migration.

Epic: none
Release note: None

@rail rail requested a review from a team as a code owner May 22, 2026 22:36
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 22, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-code-systems labels May 22, 2026
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 22, 2026

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rail rail self-assigned this May 22, 2026
@rail rail force-pushed the backport23.2-170348-170392-170657-170670-170686-170727-170765-170779 branch from 991ffaa to 263fc73 Compare May 23, 2026 00:57
Bring release-23.2 in line with release-24.1's release-tooling stack
so the new GitHub Actions release pipeline can drive 23.2 patch
releases. This bundles the eight release-26.1 PRs already backported
to 24.1 (cockroachdb#170348, cockroachdb#170392, cockroachdb#170657, cockroachdb#170670, cockroachdb#170686, cockroachdb#170727,
cockroachdb#170765, cockroachdb#170779).

Mirrors the release-24.1 (cockroachdb#170823) recipe: legacy email/Jira release
tooling that release-23.2 still carries is replaced wholesale with
the post-PR state from release-26.1 (tip 97b3f3e).

Trimmed for release-23.2's scope — these workflows / scripts were
intentionally dropped because the corresponding pipeline isn't run
on this branch:
- IBM build/sign infrastructure (build-per-platform-ibm,
  build-docker-ibm, ibm-signing, release-sign-ibm.sh): release-23.2
  does not ship IBM / linux-s390x builds.
- Cloud-only image (publish-cloud-only, cloud-rollout,
  release-cloud-only.sh, release-cloud-rollout.sh,
  build-cockroach-release-cloud-only.sh): no cloud-only image
  build/publish on this branch.
- RAFA rollout (create-rafa-prs, release-publish-rafa-prs.sh):
  release-23.2 doesn't open RAFA PRs.

Other adjustments mirror the 24.1 backport:
- cockroachdb/version added as a new dep at the May 2025 pin so the
  new pkg/cmd/release can use version.IncPreRelease / IncPatch.
  go-github/v61, plus transitive bumps of cockroachdb/errors v1.11.3,
  getsentry/sentry-go v0.27.0, google/go-cmp v0.6.0, and
  stretchr/testify v1.10.0.
- Orphaned deps dropped: andygrunwald/go-jira, google/go-github/v42,
  indirect trivago/tgo. DEPS.bzl + distdir_files.bzl updated.
- verify_docker_image reverted to detect FIPS via Go version +
  OpenSSL fingerprint (release-23.2's cockroach doesn't emit
  "FIPS enabled: true").
- TEAMCITY_BUILD_PROPERTIES_FILE mount removed from run_bazel.
- linux-s390x dropped from matrices.
- build-cockroach-release-per-platform.sh reverted to
  publish-provisional-artifacts and restores --build-arg fips_enabled=1.

Release justification: release-tooling backport for GHA migration.

Epic: none
Release note: None
@rail rail force-pushed the backport23.2-170348-170392-170657-170670-170686-170727-170765-170779 branch from 263fc73 to 8d30924 Compare May 23, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-code-systems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants