json: fix AsText() quoting of non-finite float values#170833
Draft
michae2 wants to merge 1 commit into
Draft
Conversation
jsonNumber.AsText() was delegating to jsonNumber.String(), which goes through Format() and wraps non-finite values (NaN, +Inf, -Inf) in quotes for valid JSON serialization. This caused the ->> operator to return "NaN" instead of NaN, making (jsonb ->> key)::float fail with "could not parse" errors—a problem hit by the sql activity update job. Fix by calling apd.Decimal.String() directly in AsText(), bypassing the JSON quoting. This matches jsonString.AsText() which also strips JSON encoding. Fixes: cockroachdb#170623 Release note (bug fix): Fixed a bug where extracting non-finite float values (NaN, Infinity, -Infinity) from JSONB using the ->> operator returned quoted strings (e.g. "NaN"), causing ::float casts to fail. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonNumber.AsText() was delegating to jsonNumber.String(), which goes through Format() and wraps non-finite values (NaN, +Inf, -Inf) in quotes for valid JSON serialization. This caused the ->> operator to return "NaN" instead of NaN, making (jsonb ->> key)::float fail with "could not parse" errors—a problem hit by the sql activity update job.
Fix by calling apd.Decimal.String() directly in AsText(), bypassing the JSON quoting. This matches jsonString.AsText() which also strips JSON encoding.
Fixes: #170623
Release note (bug fix): Fixed a bug where extracting non-finite float values (NaN, Infinity, -Infinity) from JSONB using the ->> operator returned quoted strings (e.g. "NaN"), causing ::float casts to fail.