release-25.4: sql/importer: cap metamorphic batch sizes in TestImportCSVStmt#170140
Merged
trunk-io[bot] merged 1 commit intoMay 12, 2026
Merged
Conversation
The test has been timing out under metamorphic builds when `kv-batch-size` and `datum-row-converter-batch-size` are randomized to their minimum (1). With 18 subtests sharing one cluster, those values blow through the 15-minute package timeout. Override both to 10 in the test setup. Adds TestingRaiseDefaultKVBatchSize to pkg/sql/row since `kv-batch-size` had no testing setter; the existing TestingSetDatumRowConverterBatchSize covers the other. Local timing with both constants forced to 1 vs 10: 74.6s -> 28.2s. Fixes: cockroachdb#167087 Release note: None
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
Contributor
|
😎 Merged successfully - details. |
blathers-crl
Bot
added
backport
Member
|
This change is |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
mw5h
approved these changes
May 11, 2026
Collaborator
Author
|
TFTR /trunk merge |
trunk-io
Bot
merged commit e15b0f6
into
cockroachdb:release-25.4
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #170013.
/cc @cockroachdb/release
The test has been timing out under metamorphic builds when
kv-batch-sizeanddatum-row-converter-batch-sizeare randomized to their minimum (1). With 18 subtests sharing one cluster, those values blow through the 15-minute package timeout.Override both to 10 in the test setup. Adds TestingRaiseDefaultKVBatchSize to pkg/sql/row since
kv-batch-sizehad no testing setter; the existing TestingSetDatumRowConverterBatchSize covers the other.Local timing with both constants forced to 1 vs 10: 74.6s -> 28.2s.
Fixes: #167087
Release note: None
Release justification: test-only change