Skip to content

release-25.4: server: wait for full replication in TestCheckRestartSafe_Criticality#170133

Open
dhartunian wants to merge 1 commit into
cockroachdb:release-25.4from
dhartunian:blathers/backport-release-25.4-169990
Open

release-25.4: server: wait for full replication in TestCheckRestartSafe_Criticality#170133
dhartunian wants to merge 1 commit into
cockroachdb:release-25.4from
dhartunian:blathers/backport-release-25.4-169990

Conversation

@dhartunian
Copy link
Copy Markdown
Collaborator

Backport 1/1 commits from #169990 on behalf of @dhartunian.


The test asserts zero under-replicated ranges before draining, but
doesn't wait for the cluster to finish initial replication after
startup. Under CI resource pressure (the failing run logged "disk
slowness detected: unable to sync log files within 10s"), ranges may
still be up-replicating when the assertion fires, causing 78
under-replicated ranges where zero were expected.

Add WaitForFullReplication() after cluster start, matching the
pattern already used by TestCheckRestartSafe_RangeStatus and other
tests in the same file. Also remove a duplicate assertion.

Fixes: #167850
Epic: none
Release note: None


Release justification:

The test asserts zero under-replicated ranges before draining, but
doesn't wait for the cluster to finish initial replication after
startup. Under CI resource pressure, ranges may still be
up-replicating when the assertion fires. Also remove a duplicate
assertion.

Fixes: cockroachdb#167850
Epic: none
Release note: None

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@dhartunian dhartunian force-pushed the blathers/backport-release-25.4-169990 branch from 131b342 to 5744a0e Compare May 11, 2026 15:47
@dhartunian dhartunian requested review from a team as code owners May 11, 2026 15:47
@dhartunian dhartunian requested review from jasonlmfong and removed request for a team May 11, 2026 15:47
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 11, 2026
@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented May 11, 2026

Merging to release-25.4 in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 11, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-observability labels May 11, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 11, 2026

Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link)

@blathers-crl blathers-crl Bot added backport-failed backport-test-only Used to denote the backport has only non-production changes and removed backport-failed labels May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Reminder: it has been 2 weeks please merge or close your backport!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot. T-observability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants