Skip to content

release-25.4: workload/schemachange: don't predict deps on DROP COLUMN#170010

Open
spilchen wants to merge 1 commit intocockroachdb:release-25.4from
spilchen:backport25.4-169328
Open

release-25.4: workload/schemachange: don't predict deps on DROP COLUMN#170010
spilchen wants to merge 1 commit intocockroachdb:release-25.4from
spilchen:backport25.4-169328

Conversation

@spilchen
Copy link
Copy Markdown
Contributor

@spilchen spilchen commented May 8, 2026

Backport 1/1 commits from #169328.

/cc @cockroachdb/release


The schemachange workload tried to predict precisely when DROP COLUMN would fail with DependentObjectsStillExist. Keeping that prediction in sync with the schema changer has been a steady source of flakes.

Move the error to potentialExecErrors so it is permitted but not required, and delete the dependency-detection helpers that fed the old prediction.

Resolves #168658

Release note: None
Epic: none

Release justification: test only fix

The schemachange workload tried to predict precisely when DROP COLUMN
would fail with DependentObjectsStillExist. Keeping that prediction
in sync with the schema changer has been a steady source of flakes.

Move the error to potentialExecErrors so it is permitted but not
required, and delete the dependency-detection helpers that fed the
old prediction.

Resolves cockroachdb#168658

Release note: None
Epic: none
@spilchen spilchen self-assigned this May 8, 2026
@spilchen spilchen requested a review from a team as a code owner May 8, 2026 21:11
@spilchen spilchen requested review from shailendra-patel and williamchoe3 and removed request for a team May 8, 2026 21:11
@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented May 8, 2026

Merging to release-25.4 in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 8, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels May 8, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented May 8, 2026

Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link)

@blathers-crl blathers-crl Bot added backport-failed backport-test-only Used to denote the backport has only non-production changes and removed backport-failed labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants