release-26.1: workload/schemachange: don't predict deps on DROP COLUMN#170002
Open
spilchen wants to merge 1 commit into
Open
release-26.1: workload/schemachange: don't predict deps on DROP COLUMN#170002spilchen wants to merge 1 commit into
spilchen wants to merge 1 commit into
Conversation
The schemachange workload tried to predict precisely when DROP COLUMN would fail with DependentObjectsStillExist. Keeping that prediction in sync with the schema changer has been a steady source of flakes. Move the error to potentialExecErrors so it is permitted but not required, and delete the dependency-detection helpers that fed the old prediction. Resolves cockroachdb#168658 Release note: None Epic: none
spilchen
requested review from
cpj2195 and
shailendra-patel
and removed request for
a team
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
blathers-crl
Bot
added
backport
Member
|
This change is |
blathers-crl
Bot
added
the
backport-test-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #169328.
/cc @cockroachdb/release
The schemachange workload tried to predict precisely when DROP COLUMN would fail with DependentObjectsStillExist. Keeping that prediction in sync with the schema changer has been a steady source of flakes.
Move the error to potentialExecErrors so it is permitted but not required, and delete the dependency-detection helpers that fed the old prediction.
Resolves #168658
Release note: None
Epic: none
Release justification: test only fix