changefeedccl: deflake TestChangefeedSchemaChangeNoBackfill#169986
Open
KeithCh wants to merge 1 commit intocockroachdb:masterfrom
Open
changefeedccl: deflake TestChangefeedSchemaChangeNoBackfill#169986KeithCh wants to merge 1 commit intocockroachdb:masterfrom
KeithCh wants to merge 1 commit intocockroachdb:masterfrom
Conversation
The test has many subtests, each of which involves a schema change. Since the default lease duration is 5 minutes, each subtest can take up to 5 minutes or more to complete, and the total duration can easily exceed the 15 minute timeout. Lowering the lease duration will allow the worst case subtest to complete much faster. Before: //pkg/ccl/changefeedccl:changefeedccl_test PASSED in 1191.1s Stats over 1000 runs: max = 1191.1s, min = 6.8s, avg = 34.6s, dev = 78.7s After: //pkg/ccl/changefeedccl:changefeedccl_test PASSED in 211.9s Stats over 1000 runs: max = 211.9s, min = 7.0s, avg = 27.5s, dev = 30.6s Release note: None Fixes: cockroachdb#169932
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test has many subtests, each of which involves a schema change.
Since the default lease duration is 5 minutes, each subtest can take up
to 5 minutes or more to complete due to waiting for the changefeed's
lease to expire before the schema change is applied. This means that the
total duration can sometimes exceed the 15 minute timeout. Lowering the
lease duration will allow the schema change to complete much faster.
Before:
//pkg/ccl/changefeedccl:changefeedccl_test PASSED in 1191.1s
Stats over 1000 runs: max = 1191.1s, min = 6.8s, avg = 34.6s, dev = 78.7s
After:
//pkg/ccl/changefeedccl:changefeedccl_test PASSED in 211.9s
Stats over 1000 runs: max = 211.9s, min = 7.0s, avg = 27.5s, dev = 30.6s
Release note: None
Fixes: #169932