testcluster: fix CrashNode isolation using Partitioner#166174
Open
pav-kv wants to merge 3 commits intocockroachdb:masterfrom
Open
testcluster: fix CrashNode isolation using Partitioner#166174pav-kv wants to merge 3 commits intocockroachdb:masterfrom
pav-kv wants to merge 3 commits intocockroachdb:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CrashNode's circuit breaker isolation is insufficient: it only blocks outbound RPCs from the crashing node. Server-side responses on existing gRPC streams (e.g.MsgAppRespsent during raft snapshot application) can still escape afterCrashClone, leaking false durability signals into the cluster.This PR replaces circuit breakers with the
Partitioner's bidirectional stream interceptors, which block bothSendMsgandRecvMsgon client streams.Commit 1 moves the
PartitionerfromkvnemesisintoTestCluster:EnablePartitionerflag onTestClusterArgsTestClusterhandles interceptor registration (AddServer) and address mapping (Start,startServer)kvnemesisno longer manages thePartitionerdirectly; usestc.Partitioner()Commit 2 fixes
CrashNodeisolation:isolateNodeFromPeers(circuit breakers) with bidirectional partitions viaAddPartition/RemovePartitionCrashCloneand removed afterstopServerLockedFixes #166145