allocator/mmaprototype: add test for non-voter WB rebalancing#166148
Draft
tbg wants to merge 1 commit intocockroachdb:masterfrom
Draft
allocator/mmaprototype: add test for non-voter WB rebalancing#166148tbg wants to merge 1 commit intocockroachdb:masterfrom
tbg wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Add a TestClusterState datadriven test that verifies MMA rebalances NON_VOTER replicas across stores to address WriteBandwidth imbalance, even when the leaseholder is in a different region. This scenario was previously untested: voters constrained to Region A, non-voters in Region B, with a WB imbalance among the Region B stores. The test confirms the leaseholder in Region A detects the remote WB overload and moves the non-voter from the overloaded store to the underloaded store, preserving the NON_VOTER replica type. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
|
Member
|
This change is |
themavik
reviewed
Mar 19, 2026
themavik
left a comment
themavik
left a comment
There was a problem hiding this comment.
Reviewed the changes — the implementation is clean and addresses the reported issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestClusterStatedatadriven test verifying that MMA rebalancesNON_VOTERreplicas across stores to address WriteBandwidth imbalance,even when the leaseholder is in a different region.
voter_constraints),non-voters placed in Region B, with a WB imbalance among the Region B
stores. The leaseholder in Region A detects the remote overload and
moves the non-voter, preserving the
NON_VOTERtype.Epic: CRDB-56265