release: fix stdout pollution in update-workflow-branches --print-branch#166128
Open
celiala wants to merge 1 commit intocockroachdb:masterfrom
Open
release: fix stdout pollution in update-workflow-branches --print-branch#166128celiala wants to merge 1 commit intocockroachdb:masterfrom
celiala wants to merge 1 commit intocockroachdb:masterfrom
Conversation
When --print-branch is used, the command previously wrote progress
messages ("Finding latest release branch...") and version-parse warnings
to stdout. The shell script captures stdout into RELEASE_BRANCH, so
those messages were prepended to the branch name, producing a malformed
PR title.
Fix by routing all progress/diagnostic output to stderr. The WARNING for
branches like release-1.0 and release-2.0 (which use a pre-semver naming
scheme) is removed entirely; those branches are silently skipped since
the correct latest branch is still found.
Fixes cockroachdb#166125.
Epic: None
Release note: None
Release justification: non-production (release infra) change.
Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Contributor
|
Merging to
|
Member
|
This change is |
rail
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents version-parse warnings from contaminating the PR title for updating the
update_releasesworkflow. See original PR title for #166125Problem
When the TeamCity script captures the release branch name via:
RELEASE_BRANCH=$("$RELEASE_BIN" update-workflow-branches --print-branch)progress messages and version-parse warnings were written to stdout instead of stderr, contaminating
RELEASE_BRANCH. This produced malformed PR titles like:instead of:
Fix
os.StderrWARNINGfor branches likerelease-1.0/release-2.0that use pre-semver naming — they're silently skipped (the correct latest branch is still found)--print-branchis set, suppress the "Finding latest release branch..." message entirely (no progress output needed in capture mode)Epic: None
Release note: None
Release justification: non-production (release infra) change.