release-26.1: sql: increase page size when iterating over range descs#161797
Conversation
Empirical testing has showed that if we increase the page size when iterating over the range descriptors for `crdb_internal.ranges_no_leases`, we get a minor performance improvement. Thus, this commit bumps the page size from 128 to 10k. Going higher didn't show any meaningful difference because the overhead of the virtual table generation dominated. (Testing was done on a single region cluster, so _perhaps_ it could benefit from still higher page size in multi-region clusters, but I don't think it would matter much in practice still.) Release note: None
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
rafiss
left a comment
There was a problem hiding this comment.
i don't have too much context on usages of RangeDescIteratorFactory/NewLazyIterator, but based on my read of this and the linked issue, this seems safe to backport.
|
TFTR! We're simply increasing |
Backport 1/1 commits from #161162 on behalf of @yuzefovich.
Empirical testing has showed that if we increase the page size when iterating over the range descriptors for
crdb_internal.ranges_no_leases, we get a minor performance improvement. Thus, this commit bumps the page size from 128 to 10k. Going higher didn't show any meaningful difference because the overhead of the virtual table generation dominated. (Testing was done on a single region cluster, so perhaps it could benefit from still higher page size in multi-region clusters, but I don't think it would matter much in practice still.)Informs: #160196.
Epic: None
Release note: None
Release justification: low-risk improvement for large clusters.