Skip to content

cspann: reduce unneccessary fixups#161765

Open
Lloyd-Pottiger wants to merge 1 commit intocockroachdb:masterfrom
Lloyd-Pottiger:reduce-useless-fixup
Open

cspann: reduce unneccessary fixups#161765
Lloyd-Pottiger wants to merge 1 commit intocockroachdb:masterfrom
Lloyd-Pottiger:reduce-useless-fixup

Conversation

@Lloyd-Pottiger
Copy link
Copy Markdown
Contributor

  • Added SearchOptions.DisableSplitMergeFixups (pkg/sql/vecindex/cspann/index.go:117), whereby the searcher skips ‘size-based’ split/merge fixups when this option is enabled enqueue operations (stalled-op fixups are still enqueued) (pkg/sql/vecindex/cspann/searcher.go:453).
  • The internal search for reassignFromSameLevel / startMerge enables this option under non-deterministic indexes, preventing the enqueuing of potentially stale fixups before subsequent TryMoveVector operations alter partition sizes enqueue a batch of potentially stale fixups before TryMoveVector alters partition size (pkg/sql/vecindex/cspann/fixup_split.go:539, pkg/sql/vecindex/cspann/fixup_merge.go:145).
  • Added test pkg/sql/vecindex/cspann/searcher_fixups_test.go and included Bazel target (pkg/sql/vecindex/cspann/BUILD.bazel:55); bazel test //pkg/sql/vecindex/cspann:cspann_test has been run.

Epic: None
Release: None

@Lloyd-Pottiger Lloyd-Pottiger requested a review from a team as a code owner January 26, 2026 02:43
@Lloyd-Pottiger Lloyd-Pottiger requested review from DrewKimball and removed request for a team January 26, 2026 02:43
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 26, 2026

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl Bot added the O-community Originated from the community label Jan 26, 2026
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 26, 2026

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 27, 2026

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@michae2 michae2 requested review from a team and mw5h January 27, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-community Originated from the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants