Skip to content

release-25.2: rowenc: fix panic in composite datum type checking#161744

Merged
yuzefovich merged 1 commit intorelease-25.2from
blathers/backport-release-25.2-161739
Feb 12, 2026
Merged

release-25.2: rowenc: fix panic in composite datum type checking#161744
yuzefovich merged 1 commit intorelease-25.2from
blathers/backport-release-25.2-161739

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl Bot commented Jan 24, 2026

Backport 1/1 commits from #161739 on behalf of @ZhouXing19.


Fixes #161402

Previously, composite type checking assumed all values implemented tree.CompositeDatum, causing panics when this wasn't true. Use safe type assertion to check if datum is composite before calling IsComposite().

Release note: None


Release justification: fix for high severity stability issue that causes node crashes. A test failure revealed that incorrect type assumptions in rowenc can trigger panics when processing composite types, leading to node instability and potential service disruption.

Fixes #161402

Previously, composite type checking assumed all values implemented
tree.CompositeDatum, causing panics when this wasn't true. Use safe
type assertion to check if datum is composite before calling IsComposite().

Release note: None
@blathers-crl blathers-crl Bot requested a review from a team as a code owner January 24, 2026 23:27
@blathers-crl blathers-crl Bot requested review from michae2 and removed request for a team January 24, 2026 23:27
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 24, 2026
@blathers-crl blathers-crl Bot requested a review from yuzefovich January 24, 2026 23:27
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Jan 24, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Jan 24, 2026
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Jan 24, 2026

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Jan 24, 2026

✅ PR #161744 is compliant with backport policy

Confidence: high
Critical bug criteria met: [Stability or security issues]
Backward compatible: true
Explanation: The pull request is compliant with the CockroachDB backport policy as it addresses a high-severity stability issue which constitutes a critical bug under the policy specifics. The description and the attached labels corroborate that the change is intended to fix an issue causing node crashes, thereby directly contributing to maintaining or restoring stability to the node operation. This meets the critical bug criteria, specifically improving stability issues and preventing node crashes. Moreover, the change has a release justification included in the PR body which explicitly states that this is a necessary fix for a stability issue.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

Reminder: it has been 2 weeks please merge or close your backport!

@yuzefovich yuzefovich merged commit f19a4fe into release-25.2 Feb 12, 2026
18 of 19 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-25.2-161739 branch February 12, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot. T-sql-queries SQL Queries Team v25.2.15

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants