ccl: fix alter_table_locality test to verify table partitioning#161741
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 26, 2026
Merged
ccl: fix alter_table_locality test to verify table partitioning#161741craig[bot] merged 1 commit intocockroachdb:masterfrom
alter_table_locality test to verify table partitioning#161741craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This test creates several mutiregion tables and performs `ALTER LOCALITY` on them to verify the change. Previously, the test would repeatedly check the partitining of `regional_by_row` table. This commit fixes the test and its output to verify all table partitionings. References: cockroachdb#150946 Release note: None
Member
fqazi
approved these changes
Jan 26, 2026
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Nice find @shghasemi!
@fqazi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @shghasemi).
Contributor
Author
|
TFRT! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test creates several mutiregion tables and performs
ALTER LOCALITYon them to verify the change. Previously, the test would repeatedly check the partitining ofregional_by_rowtable. This commit fixes the test and its output to verify all table partitionings.References: #150946
Release note: None