release-25.4: tests: avoid use of loopback dialer in Benchmark{Parallel,}Sysbench #159121
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When follow-the-workload is disabled (cockroachdb#153865), leases no longer reliably stay on n1. Since the workload clients are always created on n1, they were able to use the loopback dialer (which avoids going through the TCP layer by using inter-progress communication instead) prior to that change. We want these benchmarks to be independent of lease placement, so we disable the loopback dialer. That this was not done initially is likely an oversight. This commit will cause a a benchmark regression, but it is due to changing what is being benchmarked. The regression does not result in any production change.
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
requested review from
arulajmani,
cthumuluru-crdb and
wenyihu6
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #155057 on behalf of @tbg.
When follow-the-workload is disabled (#153865), leases no longer reliably stay on n1. Since the workload clients are always created on n1, they were able to use the loopback dialer (which avoids going through the TCP layer by using inter-progress communication instead) prior to that change.
We want these benchmarks to be independent of lease placement, so we disable the loopback dialer. That this was not done initially is likely an oversight.
This commit will cause a a benchmark regression, but it is due to changing what is being benchmarked. The regression does not result in any production change.
Informs #153866.
Epic: CRDB-55052
^-- because this is required for #153865.
Release justification: test-only change.