Skip to content

Fix Block1 transfer handling for non-piggybacked responses #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JKRhb merged 2 commits into from
Jul 15, 2025
Merged

Fix Block1 transfer handling for non-piggybacked responses #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7ef15f
fix: handle Block1 responses regardless of message type
stoprocent Jul 14, 2025
afb337c
chore(test): adding more tests to verify the block1 non-piggyback fix
stoprocent Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,10 @@ class Agent extends EventEmitter {

req.sender.reset()

if (block1 != null && packet.ack) {
if (block1 != null) {
// If the client takes too long to respond then the retry sender will send
// another packet with the previous messageId, which we've already removed.
// Handle both piggybacked (ACK with Block1) and non-piggybacked (CON with Block1) responses
const segmentedSender = req.segmentedSender
if (segmentedSender != null) {
// If there's more to send/receive, then carry on!
Expand Down
Loading
Loading