Open
Conversation
合并Nodejs4.0
Conflicts: Makefile middlewares/proxy.js package.json test/common/render_helper.test.js test/middlewares/limit.test.js test/middlewares/proxy.test.js views/sign/reset.html
Signed-off-by: zysam <expwind@gmail.com>
Member
|
这件事情我倾向于交给浏览器插件来做,或者第三方。 下次提交 pr 之前,我们先 issue 里面讨论一下吧 |
Contributor
Author
|
开始好奇这个功能怎么实现。后来发现用微信扫一扫就可以跳转到网页,再利用微信的内置工具即可分享出来。所以只须 url 生成二维码即可。 1、我试过找第三方插件代码插入的方法,如jiathis。觉得太大题小作了。 讨论是必要的,我觉得还是把代码和效果贴出来先,再考虑加不加这个功能。 |
Member
|
这东西我做过。代码在 nodeclub 里面就有。 |
Contributor
Author
|
嗯。就是看设置页有二维码,才知道有二维码的库。话题页要不要这功能呢? PC网页如果不用借第三方工具,就是让移动端扫一扫可以打开网页,再分享。 当然这功能也不是刚需,也是最近社区的微信群多了,想随手用下。 不过,加上二维码,能提升逼格。个人建议。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
见到有社员想将文章分享到微信,于是增加功能。
