Conversation
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
df99150 to
2545994
Compare
chalin
left a comment
There was a problem hiding this comment.
The Docsy links have been fixed. Please undo the changes to the pages under docs, and then rebase your PR or to a merge update. (A rebase would be better.) /cc @nate-double-u
* updating domain and netlify information Signed-off-by: Nate W <natew@cncf.io> * Update docs/services.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Nate W <natew@cncf.io> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* adding guidance for Series LLCs Signed-off-by: Nate W <natew@cncf.io> * Update docs/website-guidelines-checklist.md Signed-off-by: Nate W <natew@cncf.io> * Update docs/website-guidelines-checklist.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> * updating formatting after applying edit Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Nate W <natew@cncf.io> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Updating Nate W.'s role. Signed-off-by: Nate W <natew@cncf.io> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* Revise README, update PC role, add links Signed-off-by: Patrice Chalin <pchalin@gmail.com> * Nate's feedback Signed-off-by: Patrice Chalin <pchalin@gmail.com> --------- Signed-off-by: Patrice Chalin <pchalin@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* Add Vitess analysis document. Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> * renaming file Signed-off-by: Nate W <natew@cncf.io> * fixing formatting issues Signed-off-by: Nate W <natew@cncf.io> * fixing formatting issues Signed-off-by: Nate W <natew@cncf.io> * Update per review comments, including recommendations for FAQ and troubleshooting. Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> * Update analyses/0014-vitess/analysis.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> * Update analyses/0014-vitess/analysis.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> * removing SEO, Analytics and local search sections as out of scope for this analyis. Signed-off-by: Nate W <natew@cncf.io> * updating spelling wordlist Signed-off-by: Nate W <natew@cncf.io> * fixing format Signed-off-by: Nate W <natew@cncf.io> * removing markdown disable no-bare-urls Signed-off-by: Nate W <natew@cncf.io> * updating codefence formatting Signed-off-by: Nate W <natew@cncf.io> * disabling fence-code-langage check on quoted content Signed-off-by: Nate W <natew@cncf.io> * fixing formatting Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> Signed-off-by: Nate W <natew@cncf.io> Co-authored-by: Nate W <natew@cncf.io> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
…ncf#312) Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* adding Daniel to staff list Signed-off-by: Nate W <natew@cncf.io> * formatting and spelling Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Nate W <natew@cncf.io> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Nate W <natew@cncf.io> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Reduce htmltest CacheExpires to ~6 months, update docsy analytics link paths in analytics docs to /docs/content/feedback/#adding-analytics, and refresh static/refcache.json (LastSeen timestamps, some status codes, and a new GitHub ref entry). These changes keep link references current and shorten cache expiry for HTML tests. Signed-off-by: Patrice Chalin Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
d33f662 to
c45e8c9
Compare
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
…nalysis' into bhamilton-flatcar-analysis
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
chalin
left a comment
There was a problem hiding this comment.
LGTM in that all checks are passing an no docs pages are being edited via this PR anymore.
@nate-double-u has agreed to do a final review before this gets merged.
| | Criterion | [Rating (1-5)] | | ||
| | -------------------------- | -------------- | | ||
| | Information architecture | [rating (1-5)] | | ||
| | New user content | [rating (1-5)] | | ||
| | Content maintainability | [rating (1-5)] | | ||
| | Content creation processes | [rating (1-5)] | | ||
| | Inclusive language | [rating (1-5)] | |
There was a problem hiding this comment.
Should the ratings be set for each table-entry row?
There was a problem hiding this comment.
Yes, still to do - thx
|
Would you like me to clean up the commits @iRaindrop (ie, do a rebase)? You'd likely have to check out the PR again if you're working locally on your machine. Let me know. |
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Actually, since this is still a draft, let's leave it alone. We can squash later. |
| Flatcar GitHub repository. | ||
|
|
||
| The Flatcar website and documentation are written in Markdown and are compiled | ||
| using the "static site" generator with the "theme" and served from "platform". |
There was a problem hiding this comment.
Which static site generator, theme, and platform?
| - Contributor documentation | ||
| - Website and documentation infrastructure |
There was a problem hiding this comment.
Link to the other two sections as well.
| - **Does your code release process account for documentation creation & | ||
| updates?** | ||
|
|
||
| Supported, but not a formalized process at this time. |
There was a problem hiding this comment.
Can you be more specific about what "supported" means here?
|
|
||
| - **Who reviews and approves documentation pull requests?** | ||
|
|
||
| Team members are determined. |
There was a problem hiding this comment.
Can you be specific about who "team members" are and what "determines" them?
"Maintainers approve documentation pull requests."
or
"Maintainers delegate doc approval to experienced code contributors."
or ...?
|
|
||
| - **Does the website have a clear owner/maintainer?** | ||
|
|
||
| Team members are determined. |
| The 175 hits were "master", "disable", "abort", and "man in the middle". Of | ||
| those only "abort" would necessitate a fix on eight occurrences. |
There was a problem hiding this comment.
What does "necessitate" mean here? Is it a tier-1 term?
175 is a lot of hits.
Also, if a significant number of those require extra time and effort to remedy (if they're variable names in the API, for example), note that.
There was a problem hiding this comment.
Their word list don't always recommend changing, as for "disable"
https://inclusivenaming.org/word-lists/no-change/disable/index.html
They do recommend replacing "master", but when "master" is the name of the repository, like "main", it can't be replaced as used in the contributor documentation.
Man in the middle is "consider replacement"
https://inclusivenaming.org/word-lists/tier-3/man-in-middle/index.html
The hits are in my Google sheet, which most of you have access to, or let me know if you don't. Its on the Inclusive Hits tab.
| No, the complexity of the content is a given, and the content assumes a level of | ||
| sophistication where such verbiage would be suspicious. |
There was a problem hiding this comment.
Complex content is no guaranteed, and I don't buy the "suspicious" claim. The intent of this criterion is to avoid potentially alienating "ableist" language.
Look for phrases like "Installation is a simple matter of running the install.sh script."
Co-authored-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Co-authored-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com> Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Added template and started customizing