Fix: safe shell argument forwarding and quoting in scripts

devel/execute_on_all_databases.sh

@@ -7,7 +7,7 @@ fi
 . ./devel/all_dbs.sh || exit 2
 for db in $all
 do
-  for sql in $*
+  for sql in "$@"
   do
     echo "Execute script '$sql' on '$db' database"
     ./devel/db.sh psql "$db" < "$sql" || exit 2

devel/execute_on_all_databases_k8s.sh

@@ -34,7 +34,7 @@ fi
 . ./devel/all_dbs.sh || exit 2
 for db in $all
 do
-  for sql in $*
+  for sql in "$@"
   do
     echo "Execute script '$sql' on '$db' database"
     kubectl exec -in "devstats-${kenv2}" "${member}" -- psql "$db" < "$sql"

devel/mass_update.sh

@@ -10,7 +10,7 @@ then
   echo "You need to set TO, example FROM=abc TO=xyz $0 ./some_dir/*"
   exit 2
 fi
-for f in $*
+for f in "$@"
 do
   ls -l "$f"
   # vim --not-a-term -c "%s/${FROM}/${TO}/g" -c "wq!" "$f"

git-lfs-diff.sh

@@ -19,10 +19,10 @@ object() {
         return
     fi
 
-    Oid=$(git show $Rev:$File 2> /dev/null | grep "sha256" | cut -d ":" -f 2)
+    Oid=$(git show "${Rev}:${File}" 2> /dev/null | grep "sha256" | cut -d ":" -f 2)
     if [ "$Oid" != "" ]; then
-        Oid12=$(echo $Oid | cut -b 1-2)
-        Oid34=$(echo $Oid | cut -b 3-4)
+        Oid12=$(echo "$Oid" | cut -b 1-2)
+        Oid34=$(echo "$Oid" | cut -b 3-4)
         Object=.git/lfs/objects/$Oid12/$Oid34/$Oid
         if [ ! -e "$Object" ]; then
             echo "Missing file $File at revision $Rev"
@@ -34,14 +34,14 @@ object() {
 }
 
 
-ObjectA=$(object $RevA $File)
+ObjectA=$(object "$RevA" "$File")
 EC="$?"
 if [ "$EC" != "0" ]; then
     echo "$ObjectA"
     exit "$EC"
 fi
 
-ObjectB=$(object $RevB $File)
+ObjectB=$(object "$RevB" "$File")
 EC="$?"
 if [ "$EC" != "0" ]; then
     echo "$ObjectB"

util_sh/monitor_command.sh

@@ -34,7 +34,7 @@ then
 fi
 
 # Run command, store pid as $pid
-( $* ) & pid=$!
+( "$@" ) & pid=$!
 # Spawn watcher that waits TIMEOUT seconds and then kills command gracefully via kill -HUP, store watcher pid as $wather
 ( sleep $TIMEOUT && kill -HUP $pid ) 2>/dev/null & watcher=$!