Skip to content

fix some bugs from the user groups PR#1672

Merged
prandla merged 1 commit intocms-dev:mainfrom
prandla:groups-bugfixes
Apr 9, 2026
Merged

fix some bugs from the user groups PR#1672
prandla merged 1 commit intocms-dev:mainfrom
prandla:groups-bugfixes

Conversation

@prandla
Copy link
Copy Markdown
Member

@prandla prandla commented Apr 9, 2026

fixes some places that still tried to use contest.stop instead of group.stop. also removes the per_user_time field that was for some reason still left in the Contest class.

@pxsit ran into these in his PR.

@prandla
Copy link
Copy Markdown
Member Author

prandla commented Apr 9, 2026

(very funny how the bug in check.py wasn't caught by unit tests, because the unit tests were mocking the old interface instead of the new one.......)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.68%. Comparing base (efaab69) to head (865db34).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
- Coverage   54.69%   54.68%   -0.01%     
==========================================
  Files         336      336              
  Lines       27440    27439       -1     
==========================================
- Hits        15007    15005       -2     
- Misses      12433    12434       +1     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 54.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prandla prandla merged commit 9d9ef69 into cms-dev:main Apr 9, 2026
4 checks passed
@prandla prandla deleted the groups-bugfixes branch April 9, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants