fix some bugs from the user groups PR#1672
Merged
prandla merged 1 commit intocms-dev:mainfrom Apr 9, 2026
Merged
Conversation
Member
Author
|
(very funny how the bug in check.py wasn't caught by unit tests, because the unit tests were mocking the old interface instead of the new one.......) |
veluca93
approved these changes
Apr 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1672 +/- ##
==========================================
- Coverage 54.69% 54.68% -0.01%
==========================================
Files 336 336
Lines 27440 27439 -1
==========================================
- Hits 15007 15005 -2
- Misses 12433 12434 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes some places that still tried to use contest.stop instead of group.stop. also removes the per_user_time field that was for some reason still left in the Contest class.
@pxsit ran into these in his PR.