Skip to content

RWS: render negative times correctly#1637

Merged
prandla merged 1 commit intocms-dev:mainfrom
prandla:rws-negative-times
Feb 16, 2026
Merged

RWS: render negative times correctly#1637
prandla merged 1 commit intocms-dev:mainfrom
prandla:rws-negative-times

Conversation

@prandla
Copy link
Member

@prandla prandla commented Feb 16, 2026

currently, if there's any submissions that were made before the start of the contest, RWS renders them.. suboptimally:
image

the time formatting is from TimeView.js, and the way it's used there is actually safe for negative times, but the way it's used in UserDetails.js is not. I moved the negative handling into the format_time function itself, so that UserDetails can also correctly render them.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.70%. Comparing base (513ee4b) to head (a11121d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
+ Coverage   54.68%   54.70%   +0.01%     
==========================================
  Files         335      335              
  Lines       27354    27354              
==========================================
+ Hits        14958    14963       +5     
+ Misses      12396    12391       -5     
Flag Coverage Δ
functionaltests 0.00% <ø> (ø)
unittests 54.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prandla prandla merged commit 40b121f into cms-dev:main Feb 16, 2026
4 checks passed
@prandla prandla deleted the rws-negative-times branch February 16, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments