fix: remove unneeded main.html that added the dropdown menus at the bottom#2
Merged
andrzejnovak merged 1 commit intocms-cat:mainfrom Mar 31, 2026
Merged
fix: remove unneeded main.html that added the dropdown menus at the bottom#2andrzejnovak merged 1 commit intocms-cat:mainfrom
andrzejnovak merged 1 commit intocms-cat:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I realized at the bottom of the pages that used this plugin, the drop menus would be duplicated. For example:
https://cms-analysis.docs.cern.ch/ using
mkdocs-header-dropdownv0.3.0:https://tau-wiki.docs.cern.ch using
mkdocs-header-dropdownv0.4.0:Solution
It seems to be because
partials/header-dropdown.htmlis included twice:templates/partial/header.html,templates/main.html:It seems the latter that adds the drop menu a second time to its script block at the very bottom of
base.html. It is probably redundant, and additionally prevents the user from overridingmain.htmlthemselves for other purposes.Therefore, this PR proposes to just remove
templates/main.htmlall together. It works when I tested it locally for the CMS website. The dropmenu still appears in the header as expected, but not in the footer anymore.