Skip to content

Conversation

@patrikas-git
Copy link

This PR also:

  • Removes some methods for Stats2 which were unused.
  • Renames docs from using Stats2 to Reqmgr2 to not mislead.
  • Removes and repurposes not working job added in Integration of RelVal Status Stream Monitoring and Notification System #64
  • Removes Update button which doesn't do anything in the Workflows column (the "Update workflow" button should be used instead in Actions column, or at the bottom of the page when a Relval is checked)
  • Adds some classes and files for concern separation, e.g. application/db.py instead of using Database, which I find to be inflexible to have a wrapper around MongoClient; ReqmgrClient which uses requests lib directly instead of using ConnectionWrapper, which is also inflexible and using requests directly seems like a better idea.
  • Refactors Dashboard update service from static method to normal method and specifies tmp file path in config.cfg file
  • Removes excessive logging in controller_base.py class

Let me know if there are any suggestions for file and class names.

This is what the email sent may look like:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant