Add file rotation#4
Merged
Merged
Conversation
Also: - Name files with unix epoch seconds timestamps only - Rename RUSTCASK_MAX_FILE_SIZE to RUSTCASK_ROTATE_ACTIVE_FILE_AFTER_BYTES to better indicate what it does - Add root path and Map of readers to rotated files to RustcaskDatabase struct - Return Vec of deleted keys from rebuild_keydir to correctly build database on startup from multiple files
ChronosWS
reviewed
May 6, 2026
- Use more idiomatic method to parse env variable for active file bytes rotation threshold - Switch to using milliseconds since unix epoch for log file names - Remove unneeded flag settings for false values for OpenOptions - Handle error case when generating the next file id is the same as the currently active file id
ChronosWS
reviewed
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: